chore(v4/upgrade): apply Option C dynamicfee params in v4 migration#326
Merged
Conversation
tbruyelle
requested review from
giuliostramondo,
giunatale and
jaekwon
as code owners
tbruyelle
changed the title
tbruyelle
force-pushed
the
tbruyelle/chore/dynamicfee-params
branch
from
27cf5a9 to
346b846
Compare
julienrbrt
approved these changes
Apr 25, 2026
giunatale
added a commit
that referenced
this pull request
May 4, 2026
…micfeeParams` (#330) In #326 the code missed adding an important piece that would create a panic if state is exported and then imported again, and in any case an inconsistency that may also cause unexpected behavior: The param changes where only set in the store with `SetParams`, but where not actualized in the same way done by `UpdateParams`. This PR adds the missing `NewState` plus `SetState` required to complete #326
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #285