feat(yarn-cli): distribute runtime through release assets#754
feat(yarn-cli): distribute runtime through release assets#754TorinAsakura wants to merge 26 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 610f586f36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf7d05a2fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c83d815789
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2444f85765
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d10c6dcc24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8dcdff3a0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d57039ecd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
💡 Codex ReviewLine 32 in 31c4f53  Keep the legacy bootstrap self-contained until publish
Fresh evidence after the compatibility shim is that this checked-in legacy path is now a bootstrap pinned to the pre-publish ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d192c78d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b61fbcd0f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cfa1f1918
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be25d8c302
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .map((line) => line.match(/^(httpProxy|httpsProxy|httpsCaFilePath)\\s*:\\s*(.*?)\\s*$/)) | ||
| .filter(Boolean) | ||
| .map((match) => [match[1], parseYarnScalar(match[2])]) | ||
| .filter(([, value]) => typeof value === 'string' && value.length > 0) |
There was a problem hiding this comment.
Fresh evidence after the scoped-settings fix is that this parser now only collects top-level proxy/CA keys, so projects that configure egress only under Yarn networkSettings for GitHub hosts still cold-start without those settings. I checked node .yarn/releases/yarn.mjs config -v, which describes networkSettings as per-host network settings; with networkSettings: {github.com: {httpsProxy: ...}} or a matching CA entry, the bootstrap ignores the proxy/CA and fails before Yarn can apply its normal configuration. Please apply nested settings when the runtime API/download host matches instead of only reading globals.
Useful? React with 👍 / 👎.
1 participant
Summary
Closes #745.
This moves the Raijin Yarn runtime bundle away from git/GraphQL as the distribution channel and into GitHub Release assets:
yarn.mjsas a release asset on@atls/yarn-clireleases;yarn set version atlsand public quickstart docs to install the checked-in bootstrap path instead of rawmaster/yarn/cli/dist/yarn.mjs;.yarn/releases/yarn.mjsas a small bootstrap plus.yarn/releases/raijin-runtime.jsonduring the post-merge bundle step;yarn/cli/dist/yarn.mjsand keeps it as an ignored local build artifact;*.mjsfrom the final commit action file pattern so ignored runtime build outputs cannot be picked up by the signed GraphQL commit.Migration Note
The PR head intentionally keeps
.yarn/releases/yarn.mjsas a rebuilt full runtime bundle. The first release asset does not exist until this PR is merged and the publish workflow runs, and the PR checks themselves need a workingyarnPath.After merge, the updated publish workflow builds the runtime, uploads it to the
@atls/yarn-cliGitHub Release, and commits only the small bootstrap plus manifest. That post-merge publish commit is the point where.yarn/releases/yarn.mjsstops being the heavy runtime in git.Validation
yarn test unit release-create --test-reporter=tapyarn typecheckfor changed release, GitHub, and set-version filesyarn lintfor changed release, GitHub, set-version, and bootstrap filesyarn workspace @atls/code-github buildyarn workspace @atls/yarn-plugin-release buildyarn workspace @atls/yarn-plugin-essentials buildyarn workspace @atls/yarn-cli buildcmp -s yarn/cli/dist/yarn.mjs .yarn/releases/yarn.mjsyarn checkyarn raijin:checkgit diff --check -- ':!.yarn/releases/yarn.mjs'