Skip to content

fix(yarn-plugin-tools): preserve hook final newline#752

Merged
TorinAsakura merged 2 commits into
masterfrom
fix/husky-hook-final-newline
Jun 17, 2026
Merged

fix(yarn-plugin-tools): preserve hook final newline#752
TorinAsakura merged 2 commits into
masterfrom
fix/husky-hook-final-newline

Conversation

@TorinAsakura

Copy link
Copy Markdown
Member

Таска

Как проверять

До фикса

  1. Context: standard Raijin install hook generation in a clean repository.
    Action: run yarn install.
    Expected result: tracked Husky hook files can be rewritten without a final newline; .config/husky/pre-commit showed No newline at end of file in git diff.

После фикса

  1. Context: standard Raijin install hook generation after rebuilding the bundled CLI.
    Action: run yarn install.
    Expected result: generated Husky hook files end with 0a, and .config/husky/pre-commit no longer remains dirty after install.

Пруфы

  • yarn test unit current-yarn-executable --test-reporter=tap
  • yarn typecheck yarn/plugin-tools/sources/hooks/after-all-installed.hook.ts yarn/plugin-tools/sources/current-yarn-executable.test.ts
  • yarn lint yarn/plugin-tools/sources/hooks/after-all-installed.hook.ts yarn/plugin-tools/sources/current-yarn-executable.test.ts
  • yarn workspace @atls/yarn-plugin-tools build
  • yarn workspace @atls/yarn-cli build
  • cmp -s yarn/cli/dist/yarn.mjs .yarn/releases/yarn.mjs
  • yarn install
  • yarn check
  • yarn raijin:check

@TorinAsakura TorinAsakura self-assigned this Jun 17, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccfe781689

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread yarn/plugin-tools/sources/current-yarn-executable.test.ts Outdated
@TorinAsakura TorinAsakura merged commit b94d45b into master Jun 17, 2026
7 checks passed
@TorinAsakura TorinAsakura deleted the fix/husky-hook-final-newline branch June 17, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Preserve trailing newline in generated package manifests

1 participant