fix(yarn-plugin-library): clean private package publish metadata#751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
How to verify
Before fix
Action: Inspect private
yarn/*/package.jsonmanifests or pack a private Yarn plugin.Expected result: Before fix, private internal packages carried
publishConfig, mixing registry publish metadata with pack metadata.After fix
Context: private Raijin Yarn workspace manifests.
Action: Inspect private
yarn/*/package.jsonmanifests.Expected result: Private workspaces keep
private: true, do not definepublishConfig, and expose pack-only metadata through the internalraijin.packcontract consumed by@atls/yarn-plugin-library.Context: packed private Yarn plugin manifests.
Action: Pack
@atls/yarn-plugin-checksand@atls/yarn-plugin-library, then inspectpackage/package.jsoninside each archive.Expected result: Packed manifests contain dist-oriented
main,types, andexports, and contain neitherpublishConfignor the internalraijinfield.Proofs
yarn test unit before-workspace-packing --test-reporter=tappassed.yarn workspace @atls/yarn-plugin-checks pack --out /tmp/raijin-yarn-plugin-checks.tgzproof passed: packed manifest hasmain: dist/index.js,types: dist/index.d.ts,exports["."].import: ./dist/index.js, nopublishConfig, noraijin.yarn workspace @atls/yarn-plugin-library pack --out /tmp/raijin-yarn-plugin-library.tgzproof passed with the same packed manifest contract.yarn workspace @atls/yarn-plugin-library buildpassed.yarn workspace @atls/yarn-cli buildpassed.cmp -s yarn/cli/dist/yarn.mjs .yarn/releases/yarn.mjspassed.git diff --check -- ':!yarn/cli/dist/yarn.mjs' ':!.yarn/releases/yarn.mjs'passed.yarn checkexited 0. Existing unrelated lint warning remains inconfig/prettier/src/index.ts.yarn raijin:checkexited 0.