Skip to content

fix(monster): prevent spiral movement loop when overlaps creature #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ranisalt merged 7 commits into from
Mar 2, 2026
Merged

fix(monster): prevent spiral movement loop when overlaps creature #184

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
846ef37
fix(monster): prevent spiral movement loop when overlaps creature
ramon-bernardo Feb 17, 2026
59e468e
fix: indentation and use startAutoWalk method with dir param
ramon-bernardo Feb 17, 2026
4e2b979
refactor: move var to own context
ramon-bernardo Feb 17, 2026
80d174c
fix: walk on target same sqm
ramon-bernardo Feb 18, 2026
57954bd
fix: check when none dir
ramon-bernardo Feb 19, 2026
3fc0649
fix: walk on target same sqm
ramon-bernardo Feb 19, 2026
b7096e0
fix: ai bot suggestion
ramon-bernardo Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 11 additions & 19 deletions src/monster.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,30 +527,22 @@ void Monster::goToFollowCreature()
FindPathParams fpp;
getPathSearchParams(followCreature, fpp);

if (!isSummon()) {
Direction dir = DIRECTION_NONE;

if (isFleeing()) {
getDistanceStep(followCreature->getPosition(), dir, true);
} else { // maxTargetDist > 1
if (!getDistanceStep(followCreature->getPosition(), dir)) {
// if we can't get anything then let the A* calculate
updateFollowCreaturePath(fpp);
return;
}
}
const auto simpleStep = !isSummon() && (isFleeing() || fpp.maxTargetDist > 1);
if (simpleStep) {
auto direction = DIRECTION_NONE;
if (getDistanceStep(followCreature->getPosition(), direction, isFleeing())) {
hasFollowPath = true;

if (dir != DIRECTION_NONE) {
listWalkDir.clear();
listWalkDir.push_back(dir);
if (direction != DIRECTION_NONE) {
startAutoWalk(direction);
}

hasFollowPath = true;
startAutoWalk();
onFollowCreatureComplete();
return;
}
} else {
updateFollowCreaturePath(fpp);
}

updateFollowCreaturePath(fpp);
onFollowCreatureComplete();
}

Expand Down
Loading