Skip to content

Remove URI::Escape #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshSinyor wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove URI::Escape #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88404ed
Update spec/assets/coverage-flat.svg and spec/assets/coverage.svg. Re…
Apr 26, 2021
7d94fff
Update simplecov-shield.rb. Exchange line 31 'URI.encode(url)' with '…
Apr 26, 2021
3968bf8
Update simplecov-shield.rb. Reflects switch to ERB::Util.url_encode t…
Apr 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/simplecov-shield.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ def generate_shield
end

def shield_url
url = "#{SHIELD_ROOT}/#{badge_name}-#{coverage_percent}%-#{color}.svg"
url = "#{SHIELD_ROOT}/#{ERB::Util.url_encode("#{badge_name}-#{coverage_percent}%-#{color}")}.svg"
url += "?style=#{style}" if STYLES.include? style

URI.encode(url)
url
end

def coverage_percent
Expand Down Expand Up @@ -58,4 +58,4 @@ def color
@config.each do |key, val|
define_method(key) { self.class.config[key] }
end
end
end
2 changes: 1 addition & 1 deletion spec/assets/coverage-flat.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion spec/assets/coverage.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.