Implement FunctionExport serialization and fix a crash in AncestryInfo#128
Open
CrystalFerrai wants to merge 3 commits intoatenfyr:masterfrom
Open
Implement FunctionExport serialization and fix a crash in AncestryInfo#128CrystalFerrai wants to merge 3 commits intoatenfyr:masterfrom
CrystalFerrai wants to merge 3 commits intoatenfyr:masterfrom
Conversation
Author
|
Here is the asset that triggered the crash in UAsset asset = new(version);
using (MemoryStream stream = new(rawData))
using (AssetBinaryReader reader = new(stream, asset))
{
asset.Read(reader);
}TestActor.zip |
Collaborator
|
I'm struggling to reproduce the crash here. I've tried adding as a regular test via: TestUE5_6Subsection("TestActor", EngineVersion.VER_UE5_6);and also loading the uasset + uexp manually and reading from a memory stream, but neither raise an exception on this line. The test only fails due to binary equality and unparsed exports. Can you add a test demonstrating the crash and the fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FunctionExporthad TODOs in its serialization code that should be completed by these changes. For reference, I looked atUFunction::Serializein Class.cpp. The code is the same in UE 4.27 and UE 5.6. I have only tested with UE 5.6 assets.AncestryInfo.SetAsParentwhere the parameterdadhad itsValueproperty set tonullwhich triggered aNullReferenceExceptionwhen accessingdad.Value.Value.Existing unit tests all passed.