fix: fall back from incompatible stdin#1258
Open
MilesCranmerBot wants to merge 2 commits into
Open
Conversation
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input_stream="stdin"to Juliadevnullwhen Python stdin is not an interactive TTY with a valid fdThis should avoid SymbolicRegression.jl trying to
start_reading/poll frontend-owned pseudofiles such as marimo's stdin wrapper.Fixes #832
Tests
python3 -m py_compile pysr/sr.py pysr/test/test_main.pyuv run --no-project --python 3.12 --with pytest --with numpy --with pandas --with scikit-learn --with sympy --with juliacall==0.9.28 pytest pysr/test/test_main.py::TestInputStream -q3 passed); on this local machine JuliaCall/PythonCall teardown intermittently exits 139 after pytest reports success