replace after annotation with attribute#30
Open
brettmc wants to merge 3 commits intoassertwell:developfrom
Open
replace after annotation with attribute#30brettmc wants to merge 3 commits intoassertwell:developfrom
brettmc wants to merge 3 commits intoassertwell:developfrom
Conversation
PHPUnit 11 emits a deprecation warning when using annotations (@after), and they will not work in PHPUnit 12. Changing this means that the "after" functionality will not work in phpunit versions < 10, but it also should not cause an error. Users directly calling "restoreEnvironmentVariables()" would be fine, I think. See sebastianbergmann/phpunit#4502
phpunit 11 seems happy with both an annotation + attribute, and doesn't emit a deprecation warning for me. This should be backwards and forwards compatible
brettmc
force-pushed
the
phpunit-attributes
branch
from
903a154 to
670a96b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit 11 emits a deprecation warning when using annotations (@after), and they will not work in PHPUnit 12.
However, having both an annotation plus an attribute seems fine. It should be backwards-compatible since annotations are comments in earlier php versions.