Fix/streaming halt inside nested runtime#123
Merged
Merged
Conversation
… panic
stream_orderbook_channel called tx.blocking_send inside a tokio::spawn
task, which panics ("Cannot block the current thread from within a
runtime") on a multi-thread runtime — crashing any in-runtime async
consumer such as the rebalancer calling fetch_top_of_book.
Extract an async-callback core (stream_orderbook_with) shared by both
the sync-callback stream_orderbook primitive and the channel variant;
the channel now uses tx.send(entry).await, awaiting backpressure rather
than blocking the runtime thread. No public API changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.