feat: add login, register, create pack and create topic capture events#44
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis pull request introduces analytics event capture to user-submitted forms. A new ChangesAnalytics Event Capture Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/src/components/create-topic-form.tsx (1)
212-216:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
Create and Gopath skips analytics capture.Line 214–216 submits via
createTopic(...)withoutcapture(...), sotopics_create_attemptis only emitted from the default submit button path.Suggested fix
+ const trackTopicCreateAttempt = (values: CreateTopicFormFieldValues) => { + capture("topics_create_attempt", { + name: values.name, + description: values.description, + pack: packSlug, + }); + }; const onSubmit = form.handleSubmit((values) => { - capture("topics_create_attempt", { - name: values.name, - description: values.description, - pack: packSlug, - }); + trackTopicCreateAttempt(values); createNavigationModeRef.current = "continue"; createTopic({ ...values, pack: packSlug }); }, onFormValidationError); const submitForCreate = (mode: "continue" | "go") => { createNavigationModeRef.current = mode; void form.handleSubmit((values) => { + trackTopicCreateAttempt(values); createTopic({ ...values, pack: packSlug }); }, onFormValidationError)(); };🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web/src/components/create-topic-form.tsx` around lines 212 - 216, submitForCreate currently calls createTopic directly inside form.handleSubmit, so the analytics event topics_create_attempt isn't emitted for the "go" path; update the submitForCreate handler to call the analytics capture(...) with the same payload (including pack: packSlug) before invoking createTopic (or wrap createTopic call inside capture's callback if your capture utility expects a callback), referencing submitForCreate, createNavigationModeRef, form.handleSubmit, and createTopic to locate the code; ensure the capture call runs for both "continue" and "go" modes so analytics are always emitted.
🧹 Nitpick comments (1)
apps/web/src/hooks/use-capture.ts (1)
1-1: ⚡ Quick winAvoid file-wide lint suppression here.
Line 1 disables a rule for the whole file, but there is no
anyusage in this hook. Narrow or remove the ignore to avoid masking future type issues.Suggested cleanup
-/** biome-ignore-all lint/suspicious/noExplicitAny: any is used to capture any props */ import { usePostHog } from "posthog-js/react";🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web/src/hooks/use-capture.ts` at line 1, The file-wide lint suppression at the top of use-capture.ts is unnecessary and masks future typing issues; remove the biome-ignore-all comment and, if a specific `any` usage later needs suppression, add a narrow inline suppression only at that statement (e.g., adjacent to the offending variable or parameter in the useCapture hook) so the rest of the file remains checked by the rule.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/components/create-topic-form.tsx`:
- Around line 202-206: The telemetry call is sending raw free-text fields (name,
description) which may contain PII; change the capture("topics_create_attempt",
...) payload so it no longer includes verbatim text from values.name or
values.description — instead send non-identifying metadata (e.g., name_present:
boolean, name_length: number, description_present: boolean, description_length:
number) or stable irreversible hashes (e.g., sha256 of the value) if you need
deduplication, and keep packSlug as-is; update the code around the capture call
in create-topic-form.tsx to compute and send only these redacted/hashed fields
(or presence/length flags) rather than raw strings.
In `@apps/web/src/components/login-form.tsx`:
- Around line 39-43: The analytics capture call in login-form.tsx currently
sends raw PII (values.email and callbackURL); change the payload in the
capture("login_attempt", ...) invocation to avoid transmitting raw email or full
callback URL by sending non-PII fields instead — include provider, a boolean
like redirect_present = Boolean(callbackURL), and either email_domain =
values.email.split("@")[1] or a hashed email identifier if you must correlate
users, and ensure callbackURL is not sent or is reduced to domain-only; update
the capture call site accordingly.
In `@apps/web/src/components/register-form.tsx`:
- Around line 73-79: The telemetry call emitting PII is the
capture("register_attempt", ...) invocation; change the payload to remove direct
identifiers (email, name, username, full callbackURL) and instead send
non-identifying metadata — e.g., email domain (extract domain from
values.email), a deterministic but non-reversible username fingerprint (e.g.,
hashed or truncated length), and a redacted callback host (extract hostname only
or boolean indicating presence of callback) — so update the capture call in
register-form.tsx to replace email, name, username, and callbackURL with these
non-identifying fields.
---
Outside diff comments:
In `@apps/web/src/components/create-topic-form.tsx`:
- Around line 212-216: submitForCreate currently calls createTopic directly
inside form.handleSubmit, so the analytics event topics_create_attempt isn't
emitted for the "go" path; update the submitForCreate handler to call the
analytics capture(...) with the same payload (including pack: packSlug) before
invoking createTopic (or wrap createTopic call inside capture's callback if your
capture utility expects a callback), referencing submitForCreate,
createNavigationModeRef, form.handleSubmit, and createTopic to locate the code;
ensure the capture call runs for both "continue" and "go" modes so analytics are
always emitted.
---
Nitpick comments:
In `@apps/web/src/hooks/use-capture.ts`:
- Line 1: The file-wide lint suppression at the top of use-capture.ts is
unnecessary and masks future typing issues; remove the biome-ignore-all comment
and, if a specific `any` usage later needs suppression, add a narrow inline
suppression only at that statement (e.g., adjacent to the offending variable or
parameter in the useCapture hook) so the rest of the file remains checked by the
rule.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 20062501-821e-4d0e-aaa4-0b4aef9fbfe3
📒 Files selected for processing (5)
apps/web/src/components/create-pack-form.tsxapps/web/src/components/create-topic-form.tsxapps/web/src/components/login-form.tsxapps/web/src/components/register-form.tsxapps/web/src/hooks/use-capture.ts
Comment on lines
+202
to
+206
| capture("topics_create_attempt", { | ||
| name: values.name, | ||
| description: values.description, | ||
| pack: packSlug, | ||
| }); |
There was a problem hiding this comment.
Avoid sending raw free-text fields to analytics.
Line 203–204 sends name and description verbatim. These fields can contain sensitive or personal data and create unnecessary privacy/compliance risk in telemetry.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/web/src/components/create-topic-form.tsx` around lines 202 - 206, The
telemetry call is sending raw free-text fields (name, description) which may
contain PII; change the capture("topics_create_attempt", ...) payload so it no
longer includes verbatim text from values.name or values.description — instead
send non-identifying metadata (e.g., name_present: boolean, name_length: number,
description_present: boolean, description_length: number) or stable irreversible
hashes (e.g., sha256 of the value) if you need deduplication, and keep packSlug
as-is; update the code around the capture call in create-topic-form.tsx to
compute and send only these redacted/hashed fields (or presence/length flags)
rather than raw strings.
Comment on lines
+39
to
+43
| capture("login_attempt", { | ||
| email: values.email, | ||
| provider: "credentials", | ||
| callbackURL: callbackURL || undefined, | ||
| }); |
There was a problem hiding this comment.
Do not emit raw email/callback URL in analytics events.
Line 40 and Line 42 include directly identifying/sensitive values. Prefer non-PII properties (e.g., provider, redirect-present boolean, domain-level or hashed identifier if truly needed).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/web/src/components/login-form.tsx` around lines 39 - 43, The analytics
capture call in login-form.tsx currently sends raw PII (values.email and
callbackURL); change the payload in the capture("login_attempt", ...) invocation
to avoid transmitting raw email or full callback URL by sending non-PII fields
instead — include provider, a boolean like redirect_present =
Boolean(callbackURL), and either email_domain = values.email.split("@")[1] or a
hashed email identifier if you must correlate users, and ensure callbackURL is
not sent or is reduced to domain-only; update the capture call site accordingly.
Comment on lines
+73
to
+79
| capture("register_attempt", { | ||
| email: values.email, | ||
| provider: "credentials", | ||
| callbackURL: callbackURL || undefined, | ||
| name: values.name, | ||
| username: values.username, | ||
| }); |
There was a problem hiding this comment.
Registration telemetry currently includes direct identifiers.
Line 74, Line 77, and Line 78 emit PII (email, name, username), and Line 76 emits URL data that may carry sensitive query params. Please reduce this to non-identifying metadata.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/web/src/components/register-form.tsx` around lines 73 - 79, The
telemetry call emitting PII is the capture("register_attempt", ...) invocation;
change the payload to remove direct identifiers (email, name, username, full
callbackURL) and instead send non-identifying metadata — e.g., email domain
(extract domain from values.email), a deterministic but non-reversible username
fingerprint (e.g., hashed or truncated length), and a redacted callback host
(extract hostname only or boolean indicating presence of callback) — so update
the capture call in register-form.tsx to replace email, name, username, and
callbackURL with these non-identifying fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit