fix: deduplicate skill references when sub-rule name matches package name#57
Merged
zachdaniel merged 1 commit intoash-project:mainfrom Feb 18, 2026
Merged
Conversation
tommeier
force-pushed
the
fix/deduplicate-skill-references
branch
3 times, most recently
from
fb92a5d to
509629a
Compare
tommeier
force-pushed
the
fix/deduplicate-skill-references
branch
from
509629a to
ce1a455
Compare
zachdaniel
approved these changes
Feb 18, 2026
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
When a package has a sub-rule file with the same name as the package itself (e.g., Phoenix ships
usage-rules/phoenix.md), the generated SKILL.md contains a duplicate reference entry:This happens because
build_skill_body/3concatenates sub-rule references and main package references without deduplication. AddedEnum.uniq/1after building the combined reference list.