feat: support offset option in relationship joins#214
Open
nallwhy wants to merge 1 commit intoash-project:mainfrom
Open
feat: support offset option in relationship joins#214nallwhy wants to merge 1 commit intoash-project:mainfrom
nallwhy wants to merge 1 commit intoash-project:mainfrom
Conversation
Adds offset support to the SQL join layer for has_one and has_many relationships. This works alongside the offset option being added to Ash core (ash-project/ash#2584). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
There was a problem hiding this comment.
Pull request overview
This PR adds support for the offset option on has_one and has_many relationships when building SQL joins in ash_sql. The implementation follows the same pattern as the existing limit option, ensuring consistent behavior across the join pipeline.
Changes:
- Added
query.offsetcheck to thehas_parent_expr?condition to trigger lateral joins when offset is present - Re-applied
relationship.offsetafter query unset operations in the relationship query pipeline - Applied offset in
limit_from_manysubqueries for bothfrom_many?andlimitcases
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zachdaniel
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offsetoption onhas_oneandhas_manyrelationships when building SQL joinsquery.offsetto thehas_parent_expr?check so offset triggers lateral joinsrelationship.offsetinrelated_queryafter the query is unsetlimit_from_manysubqueries for bothfrom_many?andlimitclausesRelated
Test plan
ASH_VERSION=local ASH_SQL_VERSION=local🤖 Generated with Claude Code