Refactor branding preference fetching logic#406
Open
kavindadimuthu wants to merge 1 commit intoasgardeo:mainfrom
Open
Refactor branding preference fetching logic#406kavindadimuthu wants to merge 1 commit intoasgardeo:mainfrom
kavindadimuthu wants to merge 1 commit intoasgardeo:mainfrom
Conversation
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the branding preferences logic in the SDK to ensure branding is only fetched and applied when explicitly enabled, rather than by default. The changes clarify the documentation and adjust the code to require
inheritFromBrandingto be set totruefor branding to be fetched.Branding preferences logic update:
inheritFromBrandingproperty in theThemePreferencesinterface to clarify that branding is only fetched when explicitly enabled, and defaults tofalse.AsgardeoProviderto only fetch branding whenpreferences.theme.inheritFromBrandingistrue, rather than when it is notfalse.enabledprop for branding inAsgardeoProviderto requirepreferences.theme.inheritFromBrandingto betrue.Related Issues
Related PRs
Checklist
Security checks