Fixed the Navbar Functionality#1296
Open
Shayan-Bhowmik wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts the Navbar layout to prevent overflow and improve responsiveness on medium-sized screens by moving the desktop nav breakpoint from md to lg and adding a dedicated mobile controls cluster (theme toggle + menu button).
Changes:
- Switched desktop navigation/auth visibility from
md:tolg:breakpoint. - Added a mobile controls section (dark mode toggle + menu button) visible below
lg. - Refined logo sizing/wrapping with
clamp()typography andshrink-0/min-w-0utilities to avoid layout breakage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+342
to
+344
| > | ||
| {isOpen ? <X size={20} /> : <Menu size={20} />} | ||
| </motion.button> |
Comment on lines
+318
to
+326
| {/* Mobile controls */} | ||
| <div className="flex lg:hidden items-center gap-2 shrink-0"> | ||
| <motion.button | ||
| whileHover={{ scale: 1.05 }} | ||
| whileTap={{ scale: 0.95 }} | ||
| onClick={handleThemeToggle} | ||
| className="p-2 rounded-xl border border-soft text-main hover:bg-[#d0f6e3]/30 dark:hover:bg-slate-800 transition-colors focus:outline-none cursor-pointer flex items-center justify-center" | ||
| aria-label="Toggle dark mode" | ||
| > |
| > | ||
| <div className="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8"> | ||
| <div className="flex justify-between items-center h-16"> | ||
| <div className="flex items-center justify-between gap-3 sm:gap-4 h-16 md:h-18 flex-nowrap"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Briefly explain the changes made.
🔗 Related Issue
Closes #1150
🛠 Changes Made
📸 Screenshots (if applicable)
Add screenshots or GIFs to explain UI changes.
✅ Checklist
🚀 Notes for Reviewers
Please check the navbar behavior at narrow widths and confirm the mobile toggle/dropdown interaction feels smooth.