Add Y and Z axes scales for Condition effects#2
Add Y and Z axes scales for Condition effects#2google-labs-jules[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update main.cpp UI to show right_sat, left_sat, right_coeff, left_coeff, deadband, and center sliders for Axis Y (_1) and Axis Z (_2). - Update ffb.cpp to populate SDL_HapticEffect.condition parameters for all 3 axes from the UI values instead of just the X axis. - Added .gitignore for the ffdstudio compiled binary. Fixes #2
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Implemented additional scales for Y and Z axes in the Condition effects setup. Modified the main.cpp UI code to add sliders for Axis Y (column 2) and Axis Z (column 3). Also modified ffb.cpp to populate all three axes for SDL_HapticEffect.condition array elements from the values in effect_data. Also added .gitignore to ignore the ffdstudio binary.
PR created automatically by Jules for task 8734724256287444872 started by @arran4