refactor(streaming_file): remove ShutdownTimeout config field #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Bento's existing shutdown_timeout configuration instead of a component-specific ShutdownTimeout field. The context passed to Close() already respects the global shutdown_timeout setting. This aligns with Bento idioms where shutdown behavior is controlled at the stream level rather than per-component.
aronchick
force-pushed
the
fix/remove-shutdown-timeout
branch
from
12c80e1 to
775f287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ShutdownTimeoutfield fromStreamingFileInputConfigshutdown_timeoutconfiguration insteadClose()already respects the global shutdown_timeout settingMotivation
This addresses reviewer feedback on PR warpstreamlabs#514 - the component should use Bento's existing shutdown mechanism rather than a component-specific timeout.
Changes
ShutdownTimeoutfield from config structClose()to rely on context deadline controlled by Bento'sshutdown_timeout