Replace Fixnum with Integer and assert_equal(nil,...) with assert_nil(...)#5
Open
jolohaga wants to merge 2 commits into
Open
Replace Fixnum with Integer and assert_equal(nil,...) with assert_nil(...)#5jolohaga wants to merge 2 commits into
jolohaga wants to merge 2 commits into
Conversation
Fixnum is deprecated since Ruby 2.4 and replaced by Integer. This commit replaces all references to Fixnum with Integer.
The tests for nil fail unless using assert_nil. This commit replaces assert_equal(nil,...) with assert_nil(...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of the
Fixnumclass in the Composite module is causing runtime errors with current versions of Ruby.Fixnumwas deprecated with Ruby 2.4 and replaced with theIntegerclass.Additionally, Minitest requires the method
assert_nil(…)instead ofassert_equal(nil,…).These two commits fix these issues.
@arirusso I'm glad to have found your gem. I'm successfully using the patched version with Ruby 3.3.6 on a generative music project.