chore(deps): bump pypdf 6.12.0 -> 6.12.2 (3 of 5 Dependabot alerts; 6.13 held)#206
Merged
Conversation
Clears 3 of 5 open pypdf advisories (medium) that are fixed within the 6.12.x line. Deliberately stays in 6.12.x: pypdf 6.13.x breaks AcroForm filling in tools/document_tools.py:578 (writer.update_page_form_field_values -> "'str' object cannot be interpreted as an integer"), which silently produces BLANK sales contracts (6 document tests fail on 6.13.0+). The remaining 2 alerts (fixed only in 6.13.0) are deferred to a separate, reviewed pypdf-6.13 compatibility fix. All document/PDF tests green on 6.12.2 (230 passed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe partial for the 5 new
pypdfDependabot alerts (all medium). Clears the 3 fixed within the 6.12.x line; the other 2 (fixed only in 6.13.0) are intentionally deferred — see below.Why not jump straight to 6.13.x
pypdf 6.13.0+ breaks AcroForm form-filling.
tools/document_tools.py:578(writer.update_page_form_field_values(page, appearance_data, auto_regenerate=False)) throws'str' object cannot be interpreted as an integer; the fill is caught + logged, so sales contracts generate BLANK. Reproduced: 6 document tests fail on 6.13.0 and 6.13.3 (filled values absent from merged packets, seller-name logic). 6.12.2 stays in the working line.Verification
pypdf==6.12.2: all document/PDF tests pass (230 passed, 0 failed). Full suite gated by CI before auto-merge.Follow-up (separate, reviewed)
A pypdf-6.13 compatibility fix in
document_tools.pyis needed to clear the last 2 alerts (#84, #85). Tracked separately — it touches regulatory contract generation, so it gets its own review againstTMHA_SalesContract.pdf.🤖 Generated with Claude Code