fix: CarloWood's fix for default timeout values#250
Open
ariane-emory wants to merge 12 commits intodevfrom
Open
fix: CarloWood's fix for default timeout values#250ariane-emory wants to merge 12 commits intodevfrom
ariane-emory wants to merge 12 commits intodevfrom
Conversation
Many callsites don’t pass duration, relying on the default. The way the default was specified was wrong, resulting in an 'undefined' value if no duration is passed instead of 5000. Passing `undefined` to setTimeout causes an immediate timeout (in practise a very shortly visible TUI toast UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a requested substitute for @CarloWood's original anomalyco#17187.
Description courtesy CarloWood:
Many callsites don’t pass duration, relying on the default. The way the default was specified was wrong, resulting in an 'undefined' value if no duration is passed instead of 5000.
Passing
undefinedto setTimeout causes an immediate timeout (in practise a very shortly visible TUI toast UI.Issue for this PR
Closes anomalyco#17191
Type of change
What does this PR do?
It fixes that the default of 5000 is actually used if nothing is passed, instead of getting undefined.
How did you verify your code works?
New testing credit to me, @ariane-emory:
Made sure that
bun typecheckandbun testpassed.Original testing credit to @CarloWood:
"I run opencode in a container with a network namespace; everything is firewalled, so I got for every attempt to connect some https:// url the vague error "Unable to connect. Is the computer able to access the url?" which showed up so short that there was hardly time to read it.
I could reproduce this simply by testing "test" and hitting enter on a prompt.
After applying this patch that changed to a neat 5 seconds long visible error, as it should."
Screenshots / recordings
No UI change other than to default timeout of existing toast.
Checklist