Open
Conversation
Adds a new experimental configuration option to control dialog background overlay behavior: - 'full' (default): Semi-transparent overlay covers entire screen (current behavior) - 'limited': No overlay outside dialog window bounds - 'none': No overlay at all This allows users to work around the TUI renderer bug where emojis disappear when semi-transparent overlays are applied. Changes: - Added dialog_background_overlay to Config.Experimental schema - Updated SDK types to include the new field - Modified Dialog component to conditionally render overlay based on setting
The dialog window was appearing in the top-left when overlay mode was set to 'limited' or 'none'. This was because the outer positioning box was being resized to match the dialog window instead of staying full screen. Now the outer box always uses full screen dimensions for proper centering, and only the backgroundColor is conditionally applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
As a new
experimental.dialog_background_overlaysetting that controls whether an overlay is applied to content outside the dialogue kwhen a dialogue is open.