fix(stabilization): allow not found images#267
Merged
Conversation
gregberge
requested review from
a team,
Copilot and
jsfez
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR modifies the image stabilization logic to allow screenshots to proceed even when images fail to load (e.g., 404 errors). Previously, the stabilization would block on broken images by checking both img.complete and img.naturalWidth > 0, which prevented screenshots from being taken when images were not found.
Changes:
- Removed the
naturalWidth > 0check from the waitForImages plugin to allow failed/not-found images
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/browser/src/global/stabilization/plugins/waitForImages.ts
Outdated
Show resolved
Hide resolved
gregberge
force-pushed
the
allow-404-images
branch
from
fef330d to
505b435
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.