You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 16, 2021. It is now read-only.
At first sight it looks good, but doesn't the renderToString() from react-dom/server use an entirely separate reconciler from the regular react-dom? I migrated away from the using the server renderer in Selectivity 3.0.1 because that turned out to be a bad idea when React 15.4 was released. I have a note about it in my release notes, but it doesn't explain the full rationale :) IIRC, the React team doesn't consider shipping the server renderer to clients a valid use case, and I'm concerned this change would leave people with a dependency of including the server renderer which inflates package sizes quite considerably.
I'll admit I moved away from using React templates with Selectivity for my own project (I just use ES6 template strings now), but I'm open to suggestions how this can be properly resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
Thank you for awesome library :) I use selectivity a lot.
I found an error when migrating from React 15 to React 16.
ReactDOM.render is extremely fast, but asynchronous. Some elements may not be rendered on time in current React plugin implementation.
We need synchronous way to render components. This PR is just one way to do it, but I think it's nice and tidy.