[SPARK-44162][CORE] Support G1GC in spark metrics#42
Closed
giggsoff wants to merge 1 commit into
Closed
Conversation
### What changes were proposed in this pull request? As a part of support JDK21, add support `G1 Concurrent GC` GarbageCollectorMXBean in Spark metrics. Refer openjdk/jdk#11341 and https://bugs.openjdk.org/browse/JDK-8297247 , the `G1 Concurrent GC` not a part of YoungGC or FullGC. So we follow the JDK definition, bring two new metrics: `ConcurrentGCCount` and `ConcurrentGCTime`. ### Why are the changes needed? add new builtin garbage collectors for metrics. ### Does this PR introduce _any_ user-facing change? Yes, will receive new metrics. ### How was this patch tested? Test in local, I will add test if necessary. Closes apache#41808 from Hisoka-X/SPARK-44162_G1GC_on_JDK21. Authored-by: Jia Fan <fanjiaeminem@qq.com> Signed-off-by: Mridul Muralidharan <mridul<at>gmail.com> (cherry picked from commit 74447ab)
Collaborator
Author
|
Seems not useful for Java 17. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As a part of support JDK21, add support
G1 Concurrent GCGarbageCollectorMXBean in Spark metrics. Refer openjdk/jdk#11341 and https://bugs.openjdk.org/browse/JDK-8297247 , theG1 Concurrent GCnot a part of YoungGC or FullGC. So we follow the JDK definition, bring two new metrics:ConcurrentGCCountandConcurrentGCTime.Why are the changes needed?
add new builtin garbage collectors for metrics.
Does this PR introduce any user-facing change? Yes, will receive new metrics.
How was this patch tested?
Test in local, I will add test if necessary.
Backported from Spark 4.0