[AQA] ADS-3029#25
Open
mantasheva-dzh wants to merge 20 commits into
Open
Conversation
KumakshevAndrei
approved these changes
Jun 23, 2026
Vyacheslav-86
suggested changes
Jun 23, 2026
|
|
||
| <configuration> | ||
|
|
||
| <!-- 1. Настройка главной файловой системы (указываем ваш MinIO бакет) --> |
There was a problem hiding this comment.
Translate to english or remove comments.
| import software.amazon.awssdk.regions.Region; | ||
| import software.amazon.awssdk.services.s3.S3Client; | ||
|
|
||
| public class IcebergTableUtils { |
There was a problem hiding this comment.
Please rename this class and other classes in utils package. Avoid word "Utils" in class and package names, it's too generic.
Use more specific names, like IcebergTableClient, DockerClientService, etc.
Package can be renamed to 'service'
| import org.apache.kafka.connect.data.Struct; | ||
| import org.apache.kafka.connect.json.JsonConverter; | ||
|
|
||
| public class Event extends BaseTestEvent { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.