ADH-8300: Fix ORC timestamp migration schema mapping#23
Open
iamlapa wants to merge 1 commit into
Open
Conversation
Convert Spark TimestampType to TimestampNTZType when staging Iceberg tables for ORC-backed Spark V1 sources. This preserves ORC/Hive TIMESTAMP semantics during snapshot/migrate and avoids ORC projection failures caused by mapping existing ORC TIMESTAMP columns to Iceberg timestamp-with-zone. Add Spark 3.5/4.0 regressions for ORC TIMESTAMP migration through both SparkActions and system.migrate, plus an ORC projection guard test.
tigrulya-exe
approved these changes
Jun 15, 2026
Collaborator
|
Please do not forget to validate over spark v4.2 with #27 merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes metadata-only migration of ORC/Hive tables with
TIMESTAMPcolumns.For ORC-backed Spark V1 source tables,
BaseTableCreationSparkActionnow converts SparkTimestampTypetoTimestampNTZTypeonly for the staged Iceberg schema. This matches the physical ORCTIMESTAMPtype and prevents reads from failing with:Can not promote TIMESTAMP type to TIMESTAMPThe change is scoped to ORC-backed sources detected via
CatalogTable.provider()orstorage().serde(). It does not change global Spark type conversion, SQL syntax, migration parameters, name mapping, partition transforms, or file import behavior.Behavior
Existing ORC/Hive
TIMESTAMPcolumns migrated bysnapshot/migrateare represented as Iceberg timestamp without zone / SparkTIMESTAMP_NTZ.write.format.default=parquetstill only affects new writes. Existing imported ORC files are not rewritten.