NGSOK-1512 Support passing of truststore to DelegatingSSLSocketFactory#29
Draft
giggsoff wants to merge 2 commits into
Draft
NGSOK-1512 Support passing of truststore to DelegatingSSLSocketFactory#29giggsoff wants to merge 2 commits into
giggsoff wants to merge 2 commits into
Conversation
1edf7aa to
6be0ec6
Compare
6be0ec6 to
a1d6ea2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Ability to provide
fs.s3a.ssl.truststoreand related options to not touch system truststore for s3a access.How was this patch tested?
Not tested for 3.4.3.1 version (tested with 3.3.6).
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?