Sync 14x b13 test#2611
Draft
RekGRpth wants to merge 946 commits into
Draft
Conversation
Commit dee663f added a new SyncRequestHandler sync_handler argument, to the SimpleLruInit function definition in src/include/access/slru.h. Add this in GPDB-specific places.
Commit be9788e in src/backend/replication/syncrep.c in the SyncRepWaitForLSN function moved the conditional return higher, adding additional conditions and a large comment. Commit e174f69 added an InterruptHoldoffCount assertion before it. However, the earlier commit 6b0e52b had already added a debug log in the same location, and commit 33a6433 added an assertion before it, and commit bdb1ea1 removed InterruptHoldoffCount assertion.
1) Commit 808e13b in src/backend/storage/file/buffile.c added a new conditional error message to the BufFileSeek function. However, earlier commit 5028054 had already done the same, but with incorrect indentation, and also added a conditional call to the BufFileFlush function. 2) Commit 808e13b added a new function BufFileTruncateShared to src/backend/storage/file/buffile.c, while earlier GPDB-specific commits had already added the functions BufFileGetFilename, BufFileSuspend, BufFileResume, BufFilePledgeSequential, BufFileStartCompression, BufFileDumpCompressedBuffer, BufFileEndCompression, BufFileLoadCompressedBuffer in the same location.
Commit 5028981 in src/backend/parser/parse_utilcmd.c removed the inh_indexes field from the CreateStmtContext structure, although it was used in the transformDistributedBy function in the GPDB. Restore it for the GPDB and add code to populate it in the transformTableLikeClause function from 7X.
Commit 9796f45 in src/bin/pgbench/pgbench.c in the initCreateTables function removed the local variable opts, replacing snprintf opts with appendPQExpBuffer query. Replace in GPDB-specific code.
Commit 06a7c31 has added a new is-bare-label argument to PG_KEYWORD. Most keywords have BARE_LABEL, allowing them to be used as labels without AS keyword, but 39 are marked AS_LABEL, requiring as. However, there are a lot of GPDB-specific keywords too, most of them without comments. Conservatively mark them AS_LABEL to avoid accidentally breaking the grammar, Also mark all GPDB-specific keywords with comments to simplify future conflict resolutions. However, some of the keywords, specifically "format" and "ignore", are present in later versions of Postgres and "format" is marked as BARE_LABEL, so mark it BARE_LABEL here too.
Commit 9796f45 in src/bin/pgbench/pgbench.c in the initCreateTables function removed the local variable opts, replacing snprintf opts with appendPQExpBuffer query. Replace in GPDB-specific code.
Commit 3d351d9 redefined pg_class.reltuples to be -1 before the first VACUUM or ANALYZE. Adapt the output of GPDB-specific tests previously missed.
…#2673) 1) Commit 9fc2122 in src/backend/commands/indexcmds.c changed the error message in the DefineIndex function. Change this in the GPDB-specific test outputs. 2) Commit 6b2c4e5 in src/backend/partitioning/partbounds.c changed the error position display in the check_new_partition_bound function. Add the error position display in the GPDB-specific test outputs.
#2692) Commit c5f42da fixed documentation for HAVING clause, however GPDB has different WINDOW clause for some reason: it is missing completely in select_into.sgml and it is missing "[, ...]" in select.sgml. The actual gram.y indicates WINDOW clause is present both in SELECT and SELECT INTO, and that WINDOW specifications can be repeated, so resolve in favor of upstream.
Commit f0f13a3 changed the output rows estimate for UPDATE without RETURNING to 0. Most tests weren't affected, since single-line EXPLAIN ignores cost diffs anyway. This test seems to be the only multi-line EXPLAIN in the test suite where these diffs matter.
Commit be9788e added a fast path for SyncRepWaitForLSN, but it relies on the synchronous_standby_names GUC, which is always empty on the coordinator. Fix it by disabling the fast path on the coordinator.
…ocking_on_standby.out" This reverts commit 96f83c7.
Commit be9788e added a fast path for SyncRepWaitForLSN, but it relies on the synchronous_standby_names GUC, which is always empty on the coordinator. Fix it by disabling the fast path on the coordinator.
Commit 7b28913 added new TAP test, however GPDB does not support PREPARE TRANSACTION, so disable that part of the test.
…rimary keys" scenario This test uses a postfix operator that is no longer supported. Fix it by using another operator type.
This error is caused by the execution logic of Hash Join Node, when the outer node does not fetch a tuple, it calls the ExecSquelchNode method let the lower nodes not to produce tuples anymore, leaving the inner node "squalched" but "un-executed" state. If the hash join needs to be rescanned, then the inner nodes has to be rescanned too if Hash Node's lefttree does not have chgParam, and finally a node does not have chgParam but "squelched" will cause ERROR. This commit resolves the issue by handling of the rescan method in HashJoin Node properly. Authored-by: wuyuhao28 <wuyuhao28@github.com> (cherry picked from commit 73517b3)
This error is caused by the execution logic of Hash Join Node, when the outer node does not fetch a tuple, it calls the ExecSquelchNode method let the lower nodes not to produce tuples anymore, leaving the inner node "squalched" but "un-executed" state. If the hash join needs to be rescanned, then the inner nodes has to be rescanned too if Hash Node's lefttree does not have chgParam, and finally a node does not have chgParam but "squelched" will cause ERROR. This commit resolves the issue by handling of the rescan method in HashJoin Node properly. Authored-by: wuyuhao28 <wuyuhao28@github.com> (cherry picked from commit 73517b3)
…rimary keys" scenario (#2701) This test uses a postfix operator that is no longer supported. Fix it by using another operator type.
Commit 257836a added restoring of the collation versions, but the ggdb modification on the catalog tables requires enabling allow_system_table_mods GUC.
Commit 5028981 in src/backend/parser/parse_utilcmd.c removed the inh_indexes field from the CreateStmtContext structure, although it was used in the transformDistributedBy function in the GPDB. Restore it for the GPDB and add code to populate it in the transformTableLikeClause function from 7X.
Commit 5d1833f statrted to use be_tls_* API for SSL information in sslinfo in extensions functions. It trims expected string produced by X509_get_subject_name at NAMEDATALEN (64) length. Vanila postgres does not have tests for sslinfo at all, they were introduced in GPDB. Since the behaviour is documented, we adjust GPDB tests.
Commit ce90f07 changed error message. Change ggdb specific tests accordingly.
Commit 257836a added restoring of the collation versions, but in the ggdb modification of the catalog tables requires enabling allow_system_table_mods GUC.
Commit 76f412a removed factorial operators, leaving only the factorial() function. Replace in GPDB-specific tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.