refactor: added notification groups#58
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces Android notification channel groups so related notifications (background workers vs timers) are organized together in system notification settings.
Changes:
- Added new string resources for notification group names.
- Created
NotificationChannelGroups and assigned existing notification channels to those groups for background workers. - Created a timers notification group and assigned the active timer notification channel to it.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds default (en) strings for the new notification groups. |
| app/src/main/res/values-no/strings.xml | Adds Norwegian string for the background notification group. |
| app/src/main/java/net/ardevd/tagius/features/background/ZombieCheckWorker.kt | Creates/uses the “background tasks” notification group for zombie alerts. |
| app/src/main/java/net/ardevd/tagius/features/background/WeeklySummaryWorker.kt | Creates/uses the “background tasks” notification group for weekly summaries. |
| app/src/main/java/net/ardevd/tagius/features/background/TimerNotificationManager.kt | Creates/uses the “timers” notification group for the active timer channel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.