fix: make offline installer image index parsing robust#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
修复现场安装失败:
Root cause
构建端生成
images/image-index.tsv时,here-doc 写入的是字面量\t,而安装端按真正 tab 读取,导致整行无法拆成component/local_ref/target_ref三列,最终三个镜像变量没有被赋值。Fix
printf写真正 TSV。\t。\t。new-api/redis/postgres三个 component。image-index.tsv前 20 行并退出,不再渲染空 image。Notes
需要重新跑 GitHub Actions 生成新的
.run包。已经下载到现场的旧.run包内嵌的是旧安装器,不能原地修复。