fix: deduplicate installer functions and harden backup/restore flows#3
Open
yuanyp8 wants to merge 1 commit into
Open
fix: deduplicate installer functions and harden backup/restore flows#3yuanyp8 wants to merge 1 commit into
yuanyp8 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
install.sh(kept single active definitions for parsing, auth preparation, backup/restore/benchmark flows and helper functions), and added--registryand--nodeport-enabledparameters withNODEPORT_ENABLEDflag and optional NodePort manifest block rendering inmanifests/innodb-mysql.yaml.backup|restore|verify-backup-restorenow require an explicit--mysql-passwordor--mysql-auth-secret, updatedprepare_runtime_auth_secretto fail fast for those actions, and addedprecheck_mysql_connectivity()which validates MySQL connectivity before launching backup/restore/verify jobs (calls added torun_backup,run_restore,verify_backup_restore).latest.txtpoints to a missing snapshot the code falls back to the newest existing*.sql.gz, and added an NFS write test (touch) during backup to fail early if snapshot directory is not writable; these changes are inmanifests/mysql-backup-support.yaml.kubectl logs -ffollowers with periodickubectl logs --tail=10polling to avoid multiple background followers, and emitting a JSON report (in addition to text) plus MySQL-8 specific compat args inmanifests/mysql-benchmark-job.yaml.Testing
bash -n install.shto validate shell syntax and it returned no errors (success).awkscan that shows no remaining duplicatedname() { ... }definitions ininstall.sh(success).install.sh,manifests/innodb-mysql.yaml,manifests/mysql-backup-support.yaml, andmanifests/mysql-benchmark-job.yaml.Codex Task