feat(crypto): Add encryption functionality#196
Merged
samuelmanzanera merged 12 commits intoarchethic-foundation:developfrom Jun 11, 2024
Merged
feat(crypto): Add encryption functionality#196samuelmanzanera merged 12 commits intoarchethic-foundation:developfrom
samuelmanzanera merged 12 commits intoarchethic-foundation:developfrom
Conversation
Generates the genesis address from a given seed
Derives the genesis address for a given service from a keychain
Encrypts a secret using a given public key
bchamagne
suggested changes
May 15, 2024
Contributor
There was a problem hiding this comment.
Hello Rudy, thanks again for a great PR.
Do you mind if I directly commit a few things on this PR?
Here's what I propose to change:
- accept multiple public keys
- add a decryptSecret function
- add a test to do a encryptSecret + decryptSecret and check input == output
bchamagne
reviewed
May 15, 2024
Contributor
|
By the way, I like what you did with JSDoc. I think we should generate the doc now. 
|
Contributor
Author
|
Yes I actually planned to use typedocs. #202 |
Co-authored-by: bchamagne <74045243+bchamagne@users.noreply.github.com>
Co-authored-by: bchamagne <74045243+bchamagne@users.noreply.github.com>
Co-authored-by: bchamagne <74045243+bchamagne@users.noreply.github.com>
samuelmanzanera
added
external-contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new encryption functionality to the crypto module. It includes the following commits:
feat(crypto): getGenesisAddress
feat(crypto): getServiceGenesisAddress
feat(crypto): encryptSecret
test(crypto): add test for encryptSecret
refactor(crypto): improve imports, typing and JSDoc
It is necessary to do an
npm installbecause the changes include updates to thepackage.jsonandpackage-lock.jsonfiles, as well as additions to thecrypto.test.tsfile.