Skip to content

Unifies and extends breakpoint and debug trap handling#33

Open
Godones wants to merge 1 commit intoarceos-org:devfrom
Godones:dev
Open

Unifies and extends breakpoint and debug trap handling#33
Godones wants to merge 1 commit intoarceos-org:devfrom
Godones:dev

Conversation

@Godones
Copy link
Copy Markdown

@Godones Godones commented Apr 1, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 1, 2026 08:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unifies breakpoint handling across architectures and extends x86_64 trap handling to include #DB (debug) traps, enabling registration of trap handlers for both breakpoint and debug events.

Changes:

  • Add BREAK_HANDLER and (x86_64-only) DEBUG_HANDLER distributed-slice trap hooks.
  • Route breakpoint traps on aarch64/riscv/loongarch64/x86_64 through a shared handler mechanism.
  • Introduce ExceptionKind::Debug (x86_64-only) and classify x86_64 debug exceptions accordingly.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/x86_64/uspace.rs Classify x86_64 debug exceptions as ExceptionKind::Debug.
src/x86_64/trap.rs Add explicit handlers for #BP and #DB and route vectors to them.
src/uspace_common.rs Add ExceptionKind::Debug behind cfg(target_arch = "x86_64").
src/trap.rs Define new distributed-slice trap hooks for breakpoint/debug handlers.
src/riscv/trap.rs Route breakpoint exceptions through BREAK_HANDLER with TrapFrame access.
src/loongarch64/trap.rs Route breakpoint exceptions through BREAK_HANDLER with TrapFrame access.
src/aarch64/uspace.rs Update breakpoint exception classification to match BRK/BKPT EC values.
src/aarch64/trap.rs Route BRK handling through BREAK_HANDLER with PC adjustment logic centralized.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Godones <chenlinfeng25@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants