Unifies and extends breakpoint and debug trap handling#33
Open
Godones wants to merge 1 commit intoarceos-org:devfrom
Open
Unifies and extends breakpoint and debug trap handling#33Godones wants to merge 1 commit intoarceos-org:devfrom
Godones wants to merge 1 commit intoarceos-org:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unifies breakpoint handling across architectures and extends x86_64 trap handling to include #DB (debug) traps, enabling registration of trap handlers for both breakpoint and debug events.
Changes:
- Add
BREAK_HANDLERand (x86_64-only)DEBUG_HANDLERdistributed-slice trap hooks. - Route breakpoint traps on aarch64/riscv/loongarch64/x86_64 through a shared handler mechanism.
- Introduce
ExceptionKind::Debug(x86_64-only) and classify x86_64 debug exceptions accordingly.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/x86_64/uspace.rs | Classify x86_64 debug exceptions as ExceptionKind::Debug. |
| src/x86_64/trap.rs | Add explicit handlers for #BP and #DB and route vectors to them. |
| src/uspace_common.rs | Add ExceptionKind::Debug behind cfg(target_arch = "x86_64"). |
| src/trap.rs | Define new distributed-slice trap hooks for breakpoint/debug handlers. |
| src/riscv/trap.rs | Route breakpoint exceptions through BREAK_HANDLER with TrapFrame access. |
| src/loongarch64/trap.rs | Route breakpoint exceptions through BREAK_HANDLER with TrapFrame access. |
| src/aarch64/uspace.rs | Update breakpoint exception classification to match BRK/BKPT EC values. |
| src/aarch64/trap.rs | Route BRK handling through BREAK_HANDLER with PC adjustment logic centralized. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Godones <chenlinfeng25@outlook.com>
equation314
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.