Porting the TypeScript tests into solidity

.gitignore

@@ -4,10 +4,13 @@ cache
 
 # Deployment outputs from `just deploy-*` scripts
 deployments
+broadcast
+logs
 
 # tooling
 node_modules
 .openzeppelin
+lib/osx-v*
 
 # testing
 coverage

README.md

@@ -171,6 +171,16 @@ forge test --gas-report    # include gas usage per test
 
 Fork tests live under `test/fork/` and run against a real RPC; standard CI excludes them. Run them locally with the appropriate RPC URL set.
 
+### DAO upgrade tests (v1.0.0 → v1.3.0 → v1.4.0)
+
+Historic-source upgrade tests live under `test-upgrade/` and run under an opt-in Foundry profile. They depend on two git worktrees of this repository pinned at the historic `v1.0.0` and `v1.3.0` commits — created on demand, no network clone required.
+
+```bash
+just test-upgrade          # auto-runs test-upgrade-setup on first invocation
+```
+
+The setup is idempotent: re-running `just test-upgrade-setup` is a no-op if the worktrees already exist. To remove them, `git worktree remove lib/osx-v1.0.0` and `git worktree remove lib/osx-v1.3.0`.
+
 See the [Foundry book](https://book.getfoundry.sh/forge/tests) for advanced options.
 
 ## Deployment

docs/modules/api/pages/framework.adoc

@@ -107,6 +107,7 @@
 :xref-PluginRepo-buildCount-uint8-: xref:framework.adoc#PluginRepo-buildCount-uint8-
 :xref-PluginRepo-tagHash-struct-PluginRepo-Tag-: xref:framework.adoc#PluginRepo-tagHash-struct-PluginRepo-Tag-
 :xref-PluginRepo-_authorizeUpgrade-address-: xref:framework.adoc#PluginRepo-_authorizeUpgrade-address-
+:xref-PluginRepo-isPermissionRestrictedForAnyAddr-bytes32-: xref:framework.adoc#PluginRepo-isPermissionRestrictedForAnyAddr-bytes32-
 :xref-PluginRepo-supportsInterface-bytes4-: xref:framework.adoc#PluginRepo-supportsInterface-bytes4-
 :xref-PermissionManager-__PermissionManager_init-address-: xref:framework.adoc#PermissionManager-__PermissionManager_init-address-
 :xref-PermissionManager-grant-address-address-bytes32-: xref:framework.adoc#PermissionManager-grant-address-address-bytes32-
@@ -122,7 +123,6 @@
 :xref-PermissionManager-_revoke-address-address-bytes32-: xref:framework.adoc#PermissionManager-_revoke-address-address-bytes32-
 :xref-PermissionManager-_auth-bytes32-: xref:framework.adoc#PermissionManager-_auth-bytes32-
 :xref-PermissionManager-permissionHash-address-address-bytes32-: xref:framework.adoc#PermissionManager-permissionHash-address-address-bytes32-
-:xref-PermissionManager-isPermissionRestrictedForAnyAddr-bytes32-: xref:framework.adoc#PermissionManager-isPermissionRestrictedForAnyAddr-bytes32-
 :xref-PluginRepo-MAINTAINER_PERMISSION_ID-bytes32: xref:framework.adoc#PluginRepo-MAINTAINER_PERMISSION_ID-bytes32
 :xref-PluginRepo-UPGRADE_REPO_PERMISSION_ID-bytes32: xref:framework.adoc#PluginRepo-UPGRADE_REPO_PERMISSION_ID-bytes32
 :xref-PluginRepo-buildsPerRelease-mapping-uint8----uint16-: xref:framework.adoc#PluginRepo-buildsPerRelease-mapping-uint8----uint16-
@@ -1077,6 +1077,7 @@ The plugin repository contract required for managing and publishing different pl
 * {xref-PluginRepo-buildCount-uint8-}[`++buildCount(_release)++`]
 * {xref-PluginRepo-tagHash-struct-PluginRepo-Tag-}[`++tagHash(_tag)++`]
 * {xref-PluginRepo-_authorizeUpgrade-address-}[`++_authorizeUpgrade()++`]
+* {xref-PluginRepo-isPermissionRestrictedForAnyAddr-bytes32-}[`++isPermissionRestrictedForAnyAddr(_permissionId)++`]
 * {xref-PluginRepo-supportsInterface-bytes4-}[`++supportsInterface(_interfaceId)++`]
 
 [.contract-subindex-inherited]
@@ -1095,7 +1096,6 @@ The plugin repository contract required for managing and publishing different pl
 * {xref-PermissionManager-_revoke-address-address-bytes32-}[`++_revoke(_where, _who, _permissionId)++`]
 * {xref-PermissionManager-_auth-bytes32-}[`++_auth(_permissionId)++`]
 * {xref-PermissionManager-permissionHash-address-address-bytes32-}[`++permissionHash(_where, _who, _permissionId)++`]
-* {xref-PermissionManager-isPermissionRestrictedForAnyAddr-bytes32-}[`++isPermissionRestrictedForAnyAddr(_permissionId)++`]
 
 [.contract-subindex-inherited]
 .ProtocolVersion
@@ -1376,6 +1376,10 @@ Gets the total number of builds for a given release number.
 [[PluginRepo-_authorizeUpgrade-address-]]
 ==== `[.contract-item-name]#++_authorizeUpgrade++#++(address)++` [.item-kind]#internal#
 
+[.contract-item]
+[[PluginRepo-isPermissionRestrictedForAnyAddr-bytes32-]]
+==== `[.contract-item-name]#++isPermissionRestrictedForAnyAddr++#++(bytes32 _permissionId) → bool++` [.item-kind]#internal#
+
 [.contract-item]
 [[PluginRepo-supportsInterface-bytes4-]]
 ==== `[.contract-item-name]#++supportsInterface++#++(bytes4 _interfaceId) → bool++` [.item-kind]#public#

foundry.toml

@@ -13,3 +13,9 @@ fs_permissions = [{ access = "write", path = "./deployments" }]
 
 [profile.ci]
 fuzz = { runs = 512 }
+
+# Opt-in profile for the DAO upgrade test (v1.0.0 → v1.3.0 → v1.4.0).
+# Historic sources are git worktrees at `lib/osx-v{1.0.0,1.3.0}`; run
+# `just test-upgrade-setup` once to create them
+[profile.upgrade]
+test = "test-upgrade"

justfile

@@ -28,3 +28,23 @@ build-docs ref="main":
     forge build --ast
     GITHUB_REF="{{ ref }}" python3 scripts/build-docs.py
 
+# Run the DAO upgrade test (v1.0.0 → v1.3.0 → v1.4.0)
+[group('test')]
+test-upgrade *args: test-upgrade-setup
+    FOUNDRY_PROFILE=upgrade forge test -vvv {{ args }}
+
+# Set up the historical-source worktrees needed for the upgrade test.
+[group('test')]
+test-upgrade-setup:
+    #!/usr/bin/env bash
+    set -euo pipefail
+    if [ ! -d lib/osx-v1.0.0 ]; then
+      git worktree add lib/osx-v1.0.0 c2b9d23a96654e81f22fbf91e6f334ef26a370af
+    else
+      echo "lib/osx-v1.0.0 already exists, skipping."
+    fi
+    if [ ! -d lib/osx-v1.3.0 ]; then
+      git worktree add lib/osx-v1.3.0 6f35a85f6159ae62c68776c5cff57d4e8cfe1549
+    else
+      echo "lib/osx-v1.3.0 already exists, skipping."
+    fi