feat: rm tokenHolderSync and dead code (#798)#799
Merged
Conversation
* feat: rm tokenHolderSync and dead code * feat: lint * feat: lint * feat: lint * feat: lint * feat: lint
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the tokenHolderSync functionality and related dead code, simplifying the token voting synchronization process by eliminating complex conditional logic for large tokens.
- Removes the entire
TokenHolderSyncservice and its related test files - Simplifies
LogTokenVoting.erc20Governanceby removing token eligibility checks and delegation-only sync logic - Updates type definitions to remove
ITokenSyncTagNameand related interfaces - Adds a migration to clean up existing token sync tags from the database
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/services/aragon-plugins/tokenHolderSync.ts |
Complete removal of the TokenHolderSync service |
src/services/aragon-plugins/logTokenVoting.ts |
Simplified erc20Governance flow by removing conditional sync logic |
src/types/indexer.ts |
Removed ITokenSyncTagName enum and related type definitions |
src/migrations/20250802021235-removeTokenSyncTag.ts |
Added migration to clean up existing sync tags |
src/helpers/configIndexer.ts |
Removed sync tag related utility functions |
test/unit/services/aragon-requeue/index.spec.ts |
Fixed test data to use proper 40-character hex addresses |
| Multiple test files | Removed tests related to TokenHolderSync functionality |
* feat: rm tokenHolderSync and dead code * feat: lint * feat: lint * feat: lint * feat: lint * feat: lint * feat: format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: rm tokenHolderSync and dead code
feat: lint
feat: lint
feat: lint
feat: lint
feat: lint
📝 Summary
Explain the purpose of these changes and what problem they solve.
Task: APP-0000
🔄 What Changed
✅ Checklist
🔍 Code Review
🧪 Testing
🔒 Security