Skip to content

feat: rm tokenHolderSync and dead code (#798)#799

Merged
cristianizzo merged 2 commits into
stagingfrom
development
Aug 2, 2025
Merged

feat: rm tokenHolderSync and dead code (#798)#799
cristianizzo merged 2 commits into
stagingfrom
development

Conversation

@cristianizzo

Copy link
Copy Markdown
Contributor
  • feat: rm tokenHolderSync and dead code

  • feat: lint

  • feat: lint

  • feat: lint

  • feat: lint

  • feat: lint

📝 Summary

Explain the purpose of these changes and what problem they solve.

Task: APP-0000

🔄 What Changed

💡 Use GitHub Copilot's "Generate Summary" button to auto-generate this section

✅ Checklist

🔍 Code Review

  • Self-reviewed all code changes
  • Ask AI/Copilot code review
  • Removed all debug code, console.logs, and dead code
  • Implemented error handling with try/catch blocks where needed

🧪 Testing

  • All test suites pass locally
  • Added comprehensive unit tests for new features
  • Included integration tests for end-to-end scenarios
  • Successfully tested on remote server

🔒 Security

  • Verified no secrets or credentials are exposed
  • Reviewed for common security vulnerabilities
  • Verified commit authorship - Reviewed all commits to ensure they're from team members (check for compromised accounts)

* feat: rm tokenHolderSync and dead code

* feat: lint

* feat: lint

* feat: lint

* feat: lint

* feat: lint
@cristianizzo cristianizzo marked this pull request as ready for review August 2, 2025 08:35
Copilot AI review requested due to automatic review settings August 2, 2025 08:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the tokenHolderSync functionality and related dead code, simplifying the token voting synchronization process by eliminating complex conditional logic for large tokens.

  • Removes the entire TokenHolderSync service and its related test files
  • Simplifies LogTokenVoting.erc20Governance by removing token eligibility checks and delegation-only sync logic
  • Updates type definitions to remove ITokenSyncTagName and related interfaces
  • Adds a migration to clean up existing token sync tags from the database

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/services/aragon-plugins/tokenHolderSync.ts Complete removal of the TokenHolderSync service
src/services/aragon-plugins/logTokenVoting.ts Simplified erc20Governance flow by removing conditional sync logic
src/types/indexer.ts Removed ITokenSyncTagName enum and related type definitions
src/migrations/20250802021235-removeTokenSyncTag.ts Added migration to clean up existing sync tags
src/helpers/configIndexer.ts Removed sync tag related utility functions
test/unit/services/aragon-requeue/index.spec.ts Fixed test data to use proper 40-character hex addresses
Multiple test files Removed tests related to TokenHolderSync functionality

Comment thread test/unit/services/aragon-requeue/index.spec.ts Outdated
Comment thread src/services/aragon-requeue/index.ts Outdated
Comment thread src/services/aragon-requeue/index.ts Outdated
* feat: rm tokenHolderSync and dead code

* feat: lint

* feat: lint

* feat: lint

* feat: lint

* feat: lint

* feat: format
@cristianizzo cristianizzo merged commit 3304032 into staging Aug 2, 2025
9 checks passed
cristianizzo added a commit that referenced this pull request Sep 2, 2025
* feat: rm tokenHolderSync and dead code (#798)

* feat: rm tokenHolderSync and dead code

* feat: lint

* feat: lint

* feat: lint

* feat: lint

* feat: lint

* Feat/app 4460 (#800)

* feat: rm tokenHolderSync and dead code

* feat: lint

* feat: lint

* feat: lint

* feat: lint

* feat: lint

* feat: format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants