Update to Selenium 4.40.0 +semver:feature#157
Conversation
Update license year Update DevTools references to use V144 in library and V143 in model-specific tests
WalkthroughCopyright year in LICENSE updated to 2026; two Maven dependencies bumped (aquality-selenium-core, jackson-databind). Selenium DevTools imports updated across handler classes and tests from v142/v143 to v143/v144; one test adds an explicit page-load wait and test settings increased script timeout. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labelsfeature Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java`:
- Around line 6-7: The import of NetworkConditions is invalid for v144; replace
or remove it: in NetworkSpeedEmulationTest.java remove the incorrect import
org.openqa.selenium.devtools.v144.network.model.NetworkConditions and instead
import and use org.openqa.selenium.chromium.ChromiumNetworkConditions where
NetworkConditions was referenced (or delete unused references), keeping the
existing org.openqa.selenium.devtools.v144.network.model.ConnectionType import;
update any code that constructs or types the network condition object to use
ChromiumNetworkConditions.
🧹 Nitpick comments (1)
src/main/java/aquality/selenium/browser/devtools/EmulationHandling.java (1)
25-29: Pre-existing Javadoc copy-paste error.The constructor Javadoc incorrectly references
NetworkHandlinginstead ofEmulationHandling. This is a pre-existing issue not introduced in this PR, but worth correcting.📝 Suggested fix
/** - * Initializes a new instance of the {`@link` NetworkHandling} class. + * Initializes a new instance of the {`@link` EmulationHandling} class. * * `@param` tools Instance of {`@link` DevToolsHandling}. */
|



Update license year
Update DevTools references to use V144 in library and V143 in model-specific tests