Skip to content

Optimize code #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hovn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize code #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions app/src/main/java/com/crossbowffs/nekosms/app/SettingsFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
package com.crossbowffs.nekosms.app;

import android.content.Intent;
import android.os.Build;
import android.os.Bundle;
import android.preference.Preference;
import android.preference.PreferenceFragment;
import android.provider.Settings;

import com.crossbowffs.nekosms.BuildConfig;
import com.crossbowffs.nekosms.R;
import com.crossbowffs.nekosms.consts.PreferenceConsts;
Expand All @@ -27,21 +25,7 @@ public void onCreate(Bundle savedInstanceState) {
}

// Notification settings
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
addPreferencesFromResource(R.xml.settings_notifications_v26);
Preference settingsPreference = findPreference(PreferenceConsts.KEY_NOTIFICATIONS_OPEN_SETTINGS);
settingsPreference.setOnPreferenceClickListener(new Preference.OnPreferenceClickListener() {
@Override
public boolean onPreferenceClick(Preference preference) {
Intent intent = new Intent(Settings.ACTION_APP_NOTIFICATION_SETTINGS);
intent.putExtra(Settings.EXTRA_APP_PACKAGE, NEKOSMS_PACKAGE);
startActivity(intent);
return true;
}
});
} else {
addPreferencesFromResource(R.xml.settings_notifications);
}
addPreferencesFromResource(R.xml.settings_notifications);
}

@Override
Expand Down
0 app/src/main/res/xml/shortcuts.xml → app/src/main/res/xml-v25/shortcuts.xml
View file
Open in desktop
File renamed without changes.
9 changes: 8 additions & 1 deletion ...in/res/xml/settings_notifications_v26.xml → ...in/res/xml-v26/settings_notifications.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
<Preference
android:key="pref_notifications_open_settings"
android:title="@string/pref_notifications_open_settings"
android:summary="@string/pref_notifications_open_settings_summary"/>
android:summary="@string/pref_notifications_open_settings_summary">
<intent
android:action="android.settings.APP_NOTIFICATION_SETTINGS">
<extra
android:name="android.provider.extra.APP_PACKAGE"
android:value="com.crossbowffs.nekosms" />
</intent>
</Preference>
</PreferenceCategory>
</PreferenceScreen>