Skip to content

Fix get promise never resolving #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
appy-one merged 1 commit into from
Apr 14, 2026
+5 −3
Merged

Fix get promise never resolving #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/api-web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2018,8 +2018,10 @@ export class WebApi extends Api {
// Get both, use cached value if available and server version takes too long
return new Promise((resolve, reject) => {
let wait = true, done = false;
const handledSources = [];
const gotValue = (source: 'cache' | 'server', val: { value: any; context: any; cursor?: string }) => {
this.debug.verbose(`Got ${source} value of "${path}":`, val);
handledSources.push(source);
if (done) { return; }
const { value, context, cursor } = val;
if (source === 'server') {
Expand Down Expand Up @@ -2064,9 +2066,9 @@ export class WebApi extends Api {
};
const errors = [] as Array<{ source: 'cache' | 'server', error: any }>;
const gotError = (source: 'cache' | 'server', error: any) => {
errors.push({ source, error });
if (errors.length === 2) {
// Both failed, reject with server error
handledSources.push(source);
if (handledSources.length === 2) {
// Both failed, or server failed and cache had no value, reject with server error
reject(errors.find(e => e.source === 'server')?.error);
}
};
Expand Down