IMPLEMENT: remove all biome-ignore and eslint-disable comments, fix root causes (closes #243)#247
Merged
DaveHudson merged 4 commits intomainfrom May 2, 2026
Conversation
…oot causes (closes #243) Decisions: - ops.test.ts: `as any` → `as unknown as Op` (typed coercion for invalid-kind test) - mobile-nav.tsx: hash-only `<a href="#features/download">` → `<button>` with scrollIntoView (avoids useValidAnchor false-button pattern) - SchemaPanel.tsx: dangerouslySetInnerHTML → useRef + innerHTML in useEffect (same security posture, avoids React security prop) - useClaude.ts / ChatPanel.tsx: empty-dep useEffect → useRef init guard with full deps (run-once without lying to React) - ChatThreadList.tsx: div[role=button] wrapping buttons → outer div container + inner <button> for selection + absolute-positioned action buttons (avoids nested interactive elements) - GraphCanvas.tsx: section[tabIndex=0] + onKeyDown JSX → plain div + native addEventListener in useEffect; keyboard events bubble from focused ReactFlow children - useSessionPersistence.ts: removed eslint-disable and biome-ignore; refs and store getters are stable so empty dep arrays are correct and Biome agrees Files changed: - apps/desktop/tests/store/ops.test.ts - apps/web/src/components/ui/mobile-nav.tsx - apps/desktop/src/renderer/src/components/schema/SchemaPanel.tsx - apps/desktop/src/renderer/src/chat/useClaude.ts - apps/desktop/src/renderer/src/components/chat/ChatPanel.tsx - apps/desktop/src/renderer/src/components/chat/ChatThreadList.tsx - apps/desktop/src/renderer/src/components/graph/GraphCanvas.tsx - apps/desktop/src/renderer/src/hooks/useSessionPersistence.ts
useEffect fires after the browser has already painted, causing a one-frame flash of empty content each time highlightedHtml changes. useLayoutEffect fires synchronously after the DOM mutation and before paint, which is the correct choice when the side effect directly affects what the user sees.
Adds a check:no-suppressions script that scans source files for `biome-ignore` / `eslint-disable` and fails the build. Wired into `bun run ci` so reintroductions are caught automatically. Biome 2.4 has no native rule for these patterns; `noTsIgnore` already covers `@ts-ignore`. Refs #243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #243