Skip to content

[CI] Enable Android SDK build in swift-system#269

Closed
marcprux wants to merge 4 commits into
apple:mainfrom
swift-android-sdk:main
Closed

[CI] Enable Android SDK build in swift-system#269
marcprux wants to merge 4 commits into
apple:mainfrom
swift-android-sdk:main

Conversation

@marcprux

@marcprux marcprux commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Now that swiftlang/github-workflows supports building with the Swift SDK for Android in swiftlang/github-workflows#172, we can enable the job in swift-system to prevent Android build regressions.

Other projects have recently added Android CI at swiftlang/swift-foundation#1566, swiftlang/swift-testing#1382, swiftlang/swift-subprocess#202, and swiftlang/swift-toolchain-sqlite#23.

@glessard

glessard commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

@swift-ci please test

@jrflat

jrflat commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

@marcprux I enabled the Android SDK build flag in a commit in #270 to make sure the fix indeed worked

@marcprux

marcprux commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

@marcprux I enabled the Android SDK build flag in a commit in #270 to make sure the fix indeed worked

Great! It looks like it passed!

@glessard

Copy link
Copy Markdown
Contributor

@swift-ci please test

@marcprux

Copy link
Copy Markdown
Contributor Author

It seems I had set enable_android_sdk_build: false accidentally. I've updated it to be enable_android_sdk_build: true.

@glessard

Copy link
Copy Markdown
Contributor

@marcprux false was fine for the "Build ABI Stable" job. Android has been added for the "Test" job.

@marcprux

Copy link
Copy Markdown
Contributor Author

@marcprux false was fine for the "Build ABI Stable" job. Android has been added for the "Test" job.

Oops, sorry! I've reverted.

@marcprux

marcprux commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

This PR is obsoleted by b252c12, so closing.

@marcprux marcprux closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants