Skip to content

feat!: remove deprecated quit_driver #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazuCocoa merged 1 commit into from
Dec 8, 2024
Merged

feat!: remove deprecated quit_driver #579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions lib/appium_lib_core/driver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,20 +498,6 @@ def set_implicit_wait_by_default(wait)
{}
end

# [Deprecated] Quits the driver. This method is the same as @driver.quit
# @return [void]
#
# @example
#
# @core.quit_driver
#
def quit_driver
::Appium::Logger.warn('[DEPRECATION] quit_driver will be removed. Please use @driver.quit instead.')
@driver.quit
rescue # rubocop:disable Style/RescueStandardError
nil
end

# Returns the server's version info. This method calls +driver.remote_status+ internally
#
# @return [Hash]
Expand Down
2 changes: 0 additions & 2 deletions sig/lib/appium_lib_core/driver.rbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,6 @@ module Appium

def set_implicit_wait_by_default: (untyped wait) -> untyped

def quit_driver: () -> void

def appium_server_version: () -> Hash[String, String]

private
Expand Down
Loading