fix(hce): Fixed false failure due to to multiple Select App APDU calls#42
Open
chehsing wants to merge 1 commit intoappidea:masterfrom
Open
fix(hce): Fixed false failure due to to multiple Select App APDU calls#42chehsing wants to merge 1 commit intoappidea:masterfrom
chehsing wants to merge 1 commit intoappidea:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an issue with the
SELECT_APP APDUcommand where theprocessCommandApduis triggered twice. The first invocation returnsR_APDU_OK, but the second invocation returnsR_APDU_ERROR. This causes the first successfulSELECT_APPresponse to be overwritten.This issue is observed only when the HCE app interacts with iOS devices. I suspect it might be due to some changes with the latest Android version that causes this behaviour.
To resolve this, I have updated the sequence of when
currentHCEApplication.processCommand(command)is called.Before
After
