Gate Console Logs and Centralize Debug Flag for Production Cleanliness #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable debug mode based on NODE_ENV for logging.
Change DEBUG to depend on NODE_ENV
👷 Deploy request for sketchflow-cf pending review.Visit the deploys page to approve it
|
|
@BhavikPahuja is attempting to deploy a commit to the btech1057424's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@SH20RAJ Can you check if my changes are good enough or there is more required |
Contributor
You did very basic changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Code Quality - Gate Debugging and Centralize Flag
Hello!
I am submitting this Pull Request to address the issue of debug code impacting production builds, ensuring a clean and optimal deployment. As a first-time contributor, I enjoyed contributing this maintenance fix!
Changes Implemented
This PR fixes debug code across two files and verifies the state of a third, meeting all acceptance criteria:
src/lib/fileCache.tsconst DEBUG = falsewithconst DEBUG = process.env.NODE_ENV === 'development'.DEBUGflag now correctly uses environment variables, ensuring logs are automatically disabled and removed in production.src/components/workspace/WorkspaceEditor.tsxconsole.logstatements in a conditional block:if (process.env.NODE_ENV === 'development').src/components/canvas/ShapeConnector.tsxprocess.env.NODE_ENV === 'development'. No functional changes were required for this file.Verification & Commit
I've ensured these changes will result in:
NODE_ENV.Please let me know if any further changes or testing are required!
Thank you for the opportunity to contribute.