Skip to content

ADFA-3849: Add icon support to plugin MenuItem #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daniel-ADFA merged 2 commits into from
May 15, 2026
+10 −3
Merged

ADFA-3849: Add icon support to plugin MenuItem #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dbbdea
ADFA-3849: Add icon support to plugin MenuItem
Daniel-ADFA May 14, 2026
d53402a
Merge branch 'stage' into ADFA-3849
Daniel-ADFA May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/src/main/java/com/itsaky/androidide/actions/PluginActionItem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import androidx.core.content.ContextCompat
import com.itsaky.androidide.plugins.extensions.MenuItem
import com.itsaky.androidide.plugins.manager.pluginCategory
import com.itsaky.androidide.plugins.manager.pluginTooltipTag
import com.itsaky.androidide.plugins.manager.ui.PluginDrawableResolver


class PluginActionItem(
Expand All @@ -21,7 +22,13 @@ class PluginActionItem(

init {
label = menuItem.title
icon = ContextCompat.getDrawable(context, R.drawable.ic_package)
val iconResId = menuItem.icon
icon = if (iconResId != null) {
PluginDrawableResolver.resolve(iconResId, pluginId, context)
?: ContextCompat.getDrawable(context, R.drawable.ic_package)
} else {
ContextCompat.getDrawable(context, R.drawable.ic_package)
}
location = ActionItem.Location.EDITOR_TOOLBAR
requiresUIThread = true
}
Expand Down
4 changes: 2 additions & 2 deletions plugin-api/src/main/kotlin/com/itsaky/androidide/plugins/extensions/UIExtension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ interface UIExtension : IPlugin {
fun getFabActions(): List<FabAction> = emptyList()
}

data class MenuItem(
data class MenuItem @JvmOverloads constructor(
val id: String,
val title: String,
val isEnabled: Boolean = true,
Expand All @@ -65,7 +65,7 @@ data class MenuItem(
* both the sidebar and the toolbar surfaces.
*/
val tooltipTag: String? = null,

val icon: Int? = null,
)

data class ContextMenuContext(
Expand Down
Loading