support external jwt claims to be passed downstream#113
Open
ojafri wants to merge 1 commit intoapigee:masterfrom
Open
support external jwt claims to be passed downstream#113ojafri wants to merge 1 commit intoapigee:masterfrom
ojafri wants to merge 1 commit intoapigee:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
I signed it! |
Author
|
I signed it!
…On Mon, Jun 10, 2019, 13:41 googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here (e.g. I
signed it!) and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google.com/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fapigee%2Fmicrogateway-plugins%2Fpull%2F113>
for more info*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#113?email_source=notifications&email_token=ADTRZEHTQBE74IA2GBVCM5LPZ2G5ZA5CNFSM4HWVSMY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXKS2PY#issuecomment-500510015>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADTRZEBTVA6SAZ3JEM4WVOLPZ2G5ZANCNFSM4HWVSMYQ>
.
|
Author
|
can i please request a review for this pr, this has been pending for 3+ weeks already. If this won't be reviewed, I'll close it, but would very much appreciate if it can be commented upon what's the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enhances
extauthplugin to support extracting claims from externally issuedauthorizationbearer jwt payload and add them as a customizable request headerextauth-claims-headerto be passed downstream.This is useful for passing scopes and other relevant information to downstream when authorization/access token is stripped
keep-authorization-header: falseIt also supports customizing which of the private/sensitive claims from payload are to be omitted via
extauth-exclude-claimsconfig property