fix: prevent get_request from permanently blocking requests #1684
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirza-Samad-Ahmed-Baig <Mirzasamadahmedbaig@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the file-system request queue implementation where get_request() incorrectly marked requests as in-progress, preventing them from being fetched by fetch_next_request().
Changes:
- Removed the side effect in
get_request()that incorrectly added requests to the in-progress set - Added a regression test to ensure
get_request()remains read-only and doesn't interfere with request fetching
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/crawlee/storage_clients/_file_system/_request_queue_client.py |
Removed two lines that incorrectly marked requests as in-progress in the get_request() method |
tests/unit/storage_clients/_file_system/test_fs_rq_client.py |
Added regression test verifying that get_request() doesn't prevent subsequent fetch_next_request() calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vdusek
changed the title
vdusek
approved these changes
Jan 26, 2026
Collaborator
vdusek
left a comment
vdusek
left a comment
There was a problem hiding this comment.
Hi @Mirza-Samad-Ahmed-Baig, I checked this against all other request queue client implementations (Memory, SQL, Redis, and Apify) and confirmed that none of them mark requests as in-progress in get_request. This is clearly a bug in the FS. Thanks for catching and fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• Fixed a file-system request-queue bug where get_request() incorrectly marked requests as in-progress, which could permanently block them from fetch_next_request(). I removed the side effect and added a regression test to ensure get_request() remains read-only