UNOMI-875: REST delete routes, IT closure, and Postman docs (PR9)#819
Open
sergehuber wants to merge 4 commits into
Open
UNOMI-875: REST delete routes, IT closure, and Postman docs (PR9)#819sergehuber wants to merge 4 commits into
sergehuber wants to merge 4 commits into
Conversation
Expose DELETE routes for events and sessions that shell CRUD already used, port event-collector explain and list-invalid-objects integration tests, and document the new REST operations in Postman.
Add unomi-tracing-api to itests test classpath so EventCollectorResponse getRequestTracing() resolves TraceNode at test-compile time.
…rden invalid-objects test
Adds ITs exercising DELETE /cxs/events/{id} and DELETE /cxs/profiles/sessions/{sessionId}
end-to-end, seeds a real invalid rule in testListInvalidObjects so its assertions aren't
tautological, and adds the missing eventId Postman collection variable.
… round-trip - ElasticSearchPersistenceServiceImpl.remove() targeted the wildcard search pattern instead of the write alias for rollover types, so ES silently failed to delete events/sessions while still reporting 204 (found via the new delete-endpoint ITs, OpenSearch was unaffected). - OpenSearch ISM policy now includes an ism_template so indices created by ISM's own rollover action get managed too, not just the first index Unomi creates directly. - TraceNode's computed duration getter broke JSON round-tripping; add jackson-annotations to tracing-api and @JsonIgnoreProperties(ignoreUnknown) to tolerate it. - Fix testListInvalidObjects to seed state via TypeResolutionService directly instead of rulesService.setRule(), which throws for a never-before-seen invalid rule instead of marking it invalid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain-language summary
Some delete operations for events and sessions were only available through the admin shell, not through the REST API. Operators and integrators could not remove those items over HTTP even though the server already supported it internally.
This PR adds those REST delete routes, adds integration tests for event-collector explain mode and the list-invalid-objects shell command, and updates the Postman collection so the new routes are documented.
What changed
DELETE /cxs/events/{id}on the events REST endpoint.DELETE /cxs/profiles/sessions/{sessionId}on the profiles REST endpoint.EventsCollectorITtests for explain mode with private key (200 + tracing) and public key (403).OtherCommandsIT.testListInvalidObjectsforunomi:list-invalid-objects.Test plan
mvn -pl rest test-compile -DskipTestsmvn -pl itests test-compile -DskipTests -Pintegration-testsEventsCollectorIT,OtherCommandsIT)References
UNOMI-875