UNOMI-945: Apply sanitized condition parameters and add list IT#790
Merged
Conversation
sanitizeCondition() computed filtered parameter values but stored the original entries and never applied them back onto the Condition. Mixed safe/script:: list parameters kept malicious entries in the evaluated condition even after sanitizeValue() filtered the list.
Cover propertyValues list payloads that mix safe values with script:: entries; assert the exploit file is not created.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContextJsonEndpoint.sanitizeCondition()so filtered parameter values are stored and applied viasetParameterValues()(complements the list sanitization fix already in [UNOMI-945] fix bug in context endpoint user entry filtering #778).propertyValuespayloads mixing safe values withscript::entries.Complements master #789 — fix + IT only; no REST unit tests (3.0.x has no
rest/src/testharness).Commits
b13429c2f— production fix (sanitizeCondition)d445ad6d7— IT (mvel-payload-list.json,testMVELVulnerabilityWithListPropertyValues)Test plan
mvn -pl rest -am compile -DskipTestsContextServletIT#testMVELVulnerabilityWithListPropertyValues)