UNOMI-934/935: Return 400 for invalid rule/segment create (Phase 2 PR 4)#787
Merged
Conversation
…ase 2 PR 4) Extend master’s AbstractRestExceptionMapper pattern so IllegalArgumentException and BadSegmentConditionException from POST /cxs/rules and /cxs/segments return 400 badRequest instead of 500. Service-layer validation is unchanged; adds dedicated mappers, RuntimeExceptionMapper fallback for wrapped causes, and unit tests.
2 tasks
…ceptionMapper to 400 Extend the existing wrapped-cause handling so IllegalArgumentException and BadSegmentConditionException surfaced via InternalServerErrorException also return badRequest, matching RuntimeExceptionMapper behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IllegalArgumentException(rules) andBadSegmentConditionException(segments) to HTTP 400badRequestvia dedicated JAX-RS exception mappers, extending the masterAbstractRestExceptionMapperpattern from UNOMI-928: Improve REST API error handling with dedicated exception mappers #771/UNOMI-952: Return HTTP 400 for malformed Item JSON in REST requests #777 rather than backporting 3-dev monoliths.RuntimeExceptionMapperso wrapped validation causes also return 400 (WARN log) instead of 500.RestExceptionMapperTestfor direct and wrapped validation failures.Context (Phase 2 backport audit)
RulesServiceEndPoint/SegmentServiceEndPointvsunomi-3-dev— service-layer validation already exists on master; this PR is FRESH REST error-mapping only.df5f313de). No endpoint or validation logic changes.Test plan
mvn -pl rest test -Dtest=RestExceptionMapperTest(11 tests pass)badRequest(not 500)badRequest(not 500)