fix: reduce catalog round-trips in IcebergDocument.hasNext() to improve result writes performance#4293
Open
kunwp1 wants to merge 3 commits intoapache:mainfrom
Open
fix: reduce catalog round-trips in IcebergDocument.hasNext() to improve result writes performance#4293kunwp1 wants to merge 3 commits intoapache:mainfrom
IcebergDocument.hasNext() to improve result writes performance#4293kunwp1 wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
@Xiao-zhen-Liu @bobbai00 Please review it. |
IcebergDocument.hasNext() to improve result writes performance
bobbai00
requested changes
Mar 14, 2026
Contributor
bobbai00
left a comment
There was a problem hiding this comment.
Scala side LGTM! Can you also check the python side's iceberg document's corresponding logic, change it and teset it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR addresses #4289 by optimizing
IcebergDocument.hasNext()to minimize redundant catalog round-trips. By introducing a guard condition, we ensureseekToUsableFile()and its subsequent catalog calls are only triggered when the current record iterator is fully exhausted.trueimmediately.usableFileIterator.usableFileIteratoris also empty, callseekToUsableFile().Any related issues, documentation, discussions?
Fix #4289
How was this PR tested?
storage.iceberg.table.commit.batch-sizeto 1M (matching the total record count).Was this PR authored or co-authored using generative AI tooling?
No.